Merged
Conversation
JulienRAVIA
commented
Nov 13, 2023
lnahiro
approved these changes
Jan 4, 2024
Comment on lines
+39
to
+42
| /** @var ?class-string $repository */ | ||
| $repository = $this->repository; | ||
|
|
||
| return $repository; |
There was a problem hiding this comment.
why do not return repository & update type definition on property declaration ?
Suggested change
| /** @var ?class-string $repository */ | |
| $repository = $this->repository; | |
| return $repository; | |
| return $this->repository; |
Contributor
Author
There was a problem hiding this comment.
it's for the phpDoc ;) else it's not handled
it's very temporary, this pr : #124 will overwrite it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the PHP8 migration ;)
There is one PHPStan error i don't manage to fix.
Any help to solve this one is apprecied :)